Remove confusing no-op validate: tags.
#1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
gerred
approved these changes
Jan 7, 2020
ANeumann82
approved these changes
Jan 7, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
My guess is that they were meant for https://github.com/go-validator/validator but this library does not seem to be used (any more?). We do not seem to be using these tags for anything, they are not enforced, and the current codebase violates them. I did try to make the CRD validation markers match the tags in the process of fixing #862, but there is plenty of test code which violates those rules, so it would be a bigger task at this point. Since these tags contradict the +optional markers on directly preceding lines, it is best we reduce confusion by removing them. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
My guess is that they were meant for https://github.com/go-validator/validator
but this library does not seem to be used (any more?).
We do not seem to be using these tags for anything, they are not enforced, and
the current codebase violates them.
I did try to make the CRD validation markers match the tags in the process of
fixing #862, but there is plenty of test code which violates those rules, so it
would be a bigger task at this point.
Since these tags contradict the +optional markers on directly preceding lines,
it is best we reduce confusion by removing them.