Check the type assertion on funk.Keys return value. #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
ANeumann82
approved these changes
Jan 8, 2020
gerred
approved these changes
Jan 8, 2020
zen-dog
reviewed
Jan 8, 2020
| planNames := funk.Keys(pf.Operator.Plans).([]string) | ||
| planNames, ok := funk.Keys(pf.Operator.Plans).([]string) | ||
| if !ok { | ||
| panic("funk.Keys returned unexpected type") |
There was a problem hiding this comment.
We don't panic: for the most part we os.Exit(1) with some log message before. It gives us the chance to introduce different exit codes more smoothly later. Otherwise, LGTM
|
Merging early to keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make lint happy again.
This was result of a race between merging #1223 and #1245