Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separated TestHarness API into its own package #1262

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Separated TestHarness API into its own package #1262

merged 2 commits into from
Jan 14, 2020

Conversation

ANeumann82
Copy link
Member

The TestHarness API is not really related to the KUDO api and shouldn't be in the same package. We currently generate CRDs from the structs there, although they're not installed.

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

Fixes #1261

@ANeumann82
Separated TestHarness API into it's own package to prevent CRD genera…
3ec5839 
…tion

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@ANeumann82
Fixed missing import
c5a85f5 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
nfnt
nfnt approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for this refactoring!

At some point we should also remove the deepcopy step, as this is mostly for Kubernetes types.

@ANeumann82 ANeumann82 self-assigned this Jan 10, 2020
@porridge porridge changed the title Separated TestHarness API into it's own package Separated TestHarness API into its own package Jan 10, 2020
oliviabarrick
oliviabarrick approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@oliviabarrick oliviabarrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

zen-dog
zen-dog approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _____
< Nice! >
  -----
         \   ^__^ 
          \  (oo)\_______
             (__)\       )\/\
                 ||----w |
                 ||     ||

@kensipe kensipe merged commit 046bc4d into master Jan 14, 2020
@kensipe kensipe deleted the an/separate-testharness-api branch January 14, 2020 08:57
ANeumann82 added a commit that referenced this pull request Feb 13, 2020
@ANeumann82
Separated TestHarness API into its own package (#1262)
43b7ffb 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@porridge porridge porridge approved these changes

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@oliviabarrick oliviabarrick oliviabarrick approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@jbarrick-mesosphere jbarrick-mesosphere Awaiting requested review from jbarrick-mesosphere jbarrick-mesosphere is a code owner

Assignees

@ANeumann82 ANeumann82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New CRD generation creates CRDs for testharness
6 participants
@ANeumann82 @kensipe @porridge @nfnt @zen-dog @oliviabarrick