Populate GVK in objects fetched from API server. #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
approved these changes
Jan 16, 2020
ANeumann82
approved these changes
Jan 17, 2020
kensipe
reviewed
Jan 17, 2020
pkg/kudoctl/util/kudo/kudo.go
Outdated
| @@ -127,13 +129,30 @@ func (c *Client) InstanceExistsInCluster(operatorName, namespace, version, insta | |||
| return true, nil | |||
| } | |||
|
|
|||
| // Populate the GVK from scheme, since it is cleared by design on typed objects. | |||
| // https://github.com/kubernetes/client-go/issues/413 | |||
| func setFirstGVK(object runtime.Object) error { | |||
There was a problem hiding this comment.
mentally parsing the func name "FirstGVK"... I don't understand... is this initializing?
There was a problem hiding this comment.
We're setting GVK. The value we use is the first of the available values in Scheme.ObjectKinds.
Suggestions for a better name most welcome.
kensipe
approved these changes
Jan 17, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Otherwise we're printing empty strings. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Otherwise we're printing empty strings. See the referenced issue.
Fixes #1279