Basic validation of index files #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
ANeumann82
approved these changes
Jan 15, 2020
zen-dog
reviewed
Jan 15, 2020
zen-dog
approved these changes
Jan 15, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Adds some validation of index files. This will result in a more meaningful error message when trying to use outdated repositories. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds some validation of index files. This will result in a more meaningful error message when trying to use outdated repositories as reported in #1271.
Ideally, a different validation approach will be used in the future once backwards-compatibility of KUDO has been specified. The future approach would use the
apiVersionof the index to determine validation rules.