Make WaitForCRDs work with Unstructured arguments. #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are calling WaitForCRDs with two types of arguments, but so far were only handling one of them, and silently ignoring the unstructured objects. In this latter case, this function was effectively a no-op.
| Kind: crd.Spec.Names.Kind, | ||
| }) | ||
| case *unstructured.Unstructured: | ||
| waitingFor = append(waitingFor, schema.GroupVersionKind{ |
There was a problem hiding this comment.
What happens if the unstructured object is not a CRD?
There was a problem hiding this comment.
Then it will be rejected.
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
We are calling WaitForCRDs with two types of arguments, but so far were only handling one of them, and silently ignoring the unstructured objects. In this latter case, this function was effectively a no-op. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We are calling WaitForCRDs with two types of arguments, but so far were
only handling one of them, and silently ignoring the unstructured
objects. In this latter case, this function was effectively a no-op.
Fixes #1282