Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored phase status checking. #1291

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Refactored phase status checking. #1291

merged 1 commit into from
Jan 21, 2020

Conversation

harryge00
Copy link
Contributor

@harryge00 harryge00 commented Jan 19, 2020 •
edited by zen-dog
Loading

What this PR does / why we need it:
isFinished and isInProgress is the same as here and here. So we can reuse the code.

zen-dog
zen-dog approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  ___________
< Good catch! >
  -----------
         \   ^__^ 
          \  (oo)\_______
             (__)\       )\/\
                 ||----w |
                 ||     ||

nfnt
nfnt approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing superfluous code!

@alenkacz alenkacz merged commit 23f0c85 into kudobuilder:master Jan 21, 2020
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
@harryge00 @ANeumann82
Refactored phase status checking. (#1291)
e38fb11 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harryge00 @nfnt @zen-dog @alenkacz