-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify kubernetesVersion when run 'package verify'. #1296
Conversation
aa4e3f2
to
542eb03
Compare
|
What's the diff when |
542eb03
to
6d1224d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, we should make sure that kubernetesVersion
is validated if set.
Though, currently kubernetesVersion
is an optional field. I.e., we need to support cases where kubernetesVersion == ""
, which is also valid. Please support the case where kubernetesVersion
isn't set.
So the test where kubernetesVersion == ""
should result in a successful validation while something like kubernetesVersion == "invalid"
should fail the validation.
@nfnt When
|
Interesting! I wasn't aware of this behavior in |
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
What this PR does / why we need it:
Fix #1266.
But currently, we do not compare
kubernetesVersion
withapiserver
. Only thekubernetesVersion
in theoperator.yaml
is verified.