Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: No Panic for Missing Map of Plans #1300

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Bugfix: No Panic for Missing Map of Plans #1300

merged 1 commit into from
Jan 23, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jan 22, 2020

if plans are missing from operator yaml it results in a nil map. no joy. this fixes that.

Signed-off-by: Ken Sipe kensipe@gmail.com

…oy. this fixes that

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We probably have more bugs like these lurking in the code, it's not intuitive that uninitialized maps are nil.

@kensipe kensipe merged commit 423acdb into master Jan 23, 2020
@kensipe kensipe deleted the ken/panic-fix branch January 23, 2020 19:08
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
…oy. this fixes that (#1300)

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr pushed a commit that referenced this pull request Mar 11, 2020
…oy. this fixes that (#1300)

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants