Additional Code Linters #1304
Merged
Additional Code Linters #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
alenkacz,
gerred,
jbarrick-mesosphere,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Yes, more linters please!
I'm already starting a discussion, questioning a duplicate checker with threshold of 400 lines :) But I agree with you that we should merge this first and later tighten the lll and dupl configurations and add the refactorings needed for that.
| lll: | ||
| line-length: 250 | ||
| dupl: | ||
| threshold: 400 |
There was a problem hiding this comment.
This seems like a very high threshold. The default is 15. I'm okay with having some code duplication but 400 lines seems like too much. WDYT?
There was a problem hiding this comment.
yeah... I do agree. This is what the controller/runtime project has... and tightening this results in work...
ANeumann82
approved these changes
Jan 27, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
*dupl threshold that aligns with controller-runtime * lll as a linter with a line length limit of 250 Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
*dupl threshold that aligns with controller-runtime * lll as a linter with a line length limit of 250 Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enabling a number of additional linters which aligns with other related projects such as controlller-runtime. For controller-runtime these are being moved from command-line flags into the config file with PR https://github.com/kubernetes-sigs/controller-runtime/pull/773/files
The contentious configuration I imagine is line length limit of 250. controller-runtime uses 170 which seems reasonable. We have had no limit... the result of linting with 170 limit is large. Even with 250 limit there were 9 violations which are resolved in this PR. If it's ok with reviewers... lets debate the configurations after this PR. This PR at least put some checks and limits in place that previously didn't exist.
Fixes #