Refactored YamlToObject. #1307
Merged
Refactored YamlToObject. #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
force-pushed
the
refactored-yaml-to-object
branch
from
33f0271
to
d78ce19
Compare
This was referenced Feb 4, 2020
|
|
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
This is to avoid splitting the YAML file "by hand" and instead use provided libraries.
porridge
force-pushed
the
refactored-yaml-to-object
branch
from
9ba5934
to
0fbcff2
Compare
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
This is to avoid splitting the YAML file "by hand" and instead use provided libraries. This also fixes the inconsistent treatment of whitespace-only files. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
nfnt
pushed a commit
that referenced
this pull request
Mar 9, 2020
This reverts commit 5cb9b0b. Signed-off-by: Jan Schlicht <jan@d2iq.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
This is to avoid splitting the YAML file "by hand" and instead use provided libraries. This also fixes the inconsistent treatment of whitespace-only files. Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid splitting the YAML file "by hand" and instead use
provided libraries.
What this PR does / why we need it:
Something like this was suggested in review of #1298 (in turn provoked by #1297 ).
Also, this
Fixes: #1331