Bugfix: IntegrationTest TestRestartController #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensipe
requested review from
alenkacz,
gerred,
nfnt and
zen-dog
as code owners
ANeumann82
requested changes
Jan 27, 2020
| @@ -72,7 +72,7 @@ type PlanStatus struct { | |||
| Status ExecutionStatus `json:"status,omitempty"` | |||
| Message string `json:"message,omitempty"` // more verbose explanation of the status, e.g. a detailed error message | |||
| // +nullable | |||
| LastFinishedRun metav1.Time `json:"lastFinishedRun,omitempty"` | |||
| LastFinishedRun *metav1.Time `json:"lastFinishedRun,omitempty"` | |||
There was a problem hiding this comment.
As this can now be nil, we should have checks for nil in places where this field is used, right?
I.e. in instance_types_helpers.go wasRunAfter and plan_history.go planHistory
…that it can be nil Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
force-pushed
the
ken/controller-restart-fix
branch
from
d3a1cc8
to
49304f9
Compare
Signed-off-by: Ken Sipe <kensipe@gmail.com>
…ullable but now actually is Signed-off-by: Ken Sipe <kensipe@gmail.com>
ANeumann82
approved these changes
Jan 28, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastFinishedRuna ptr so that it can benilFixes #1312
Signed-off-by: Ken Sipe kensipe@gmail.com