Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logging in kudo-cli test #1318

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

harryge00
Copy link
Contributor

@harryge00 harryge00 commented Jan 30, 2020

What this PR does / why we need it:

Original code:

		if err != nil {
			if !strings.Contains(err.Error(), tt.errMessageContains) {
				t.Errorf("%s: expected error '%s' but got '%v'", tt.name, tt.errMessageContains, err)
			}
		} else if tt.errMessageContains != "" {  
			t.Errorf("%s: expected no error but got %v", tt.name, err)

Here err is nil but tt.errMessageContains is not nil. So the error logging should be fixed

@harryge00 harryge00 force-pushed the fix-update-test branch 2 times, most recently from b517553 to 79b3693 Compare February 1, 2020 15:36
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nfnt nfnt merged commit ace6186 into kudobuilder:master Feb 3, 2020
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants