Fixed calculation of reconcile event handling for PipePods #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
ANeumann82
changed the title
alenkacz
approved these changes
Jan 31, 2020
Added basic unit test for eventFilter delete methods Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
|
Good Point. I wouldn't like a IT for this as it would probably be flaky if it failed, in my testing today it sometimes worked, sometimes not, probably depending on the order of events that the controller received, and the timing. I've added a basic unit test though, if we're going to extend the filter we can extend the test as well. |
|
@ANeumann82 I think even flaky test is a good indication that something is broken :) but alright... |
zen-dog
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Nice catch! The original implementation was correct but then I introduced funk library and broke it! 🚢
ANeumann82
added a commit
that referenced
this pull request
Feb 13, 2020
* Fixed calculation of event handling for PipePods * Added basic unit test for eventFilter delete methods Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Fixed calculation of event handling for PipePods * Added basic unit test for eventFilter delete methods Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Corrects the calculation if a reconcile should be done for DeleteEvents.
The comment in the code states that it should be skipped for PipePods, but at the moment it triggers reconciles ONLY for PipePods.
Fixes #1321