Added BasicVerifier for Tasks #1324
Conversation
Added unit test for BasicVerifier Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
| for _, tt := range pf.Operator.Tasks { | ||
| tt := tt | ||
|
|
||
| if _, err := task.Build(&tt); err != nil { |
There was a problem hiding this comment.
I like this verifier! I put the validation code in the task.go originally because we haven't had a good place for it back then. Wdyt about little refactoring: move that code and corresponding tests here?
There was a problem hiding this comment.
Refactoring might be possible. I tried it a little bit yesterday, but couldn't find a good structure, so I'm leaving it as is for now.
| ) | ||
|
|
||
| // ReferenceVerifier verifies tasks producing errors for tasks referenced in plans that do not exist and warnings for tasks which are not used in a plan | ||
| type BasicVerifier struct{} |
There was a problem hiding this comment.
More like TasksVerifier based on what it does?
| type BasicVerifier struct{} | |
| type TasksVerifier struct{} |
There was a problem hiding this comment.
That would kinda stutter on import, with task.TasksVerifier?
Maybe StructureVerifier?
There was a problem hiding this comment.
I've renamed it now to BuildVerifier, because that's what it does at the moment: Verifies that the task can be build
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
* Added BuildVerifier for Tasks * Added unit test for BuildVerifier Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
* Added BuildVerifier for Tasks * Added unit test for BuildVerifier Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
What this PR does / why we need it:
We should use the same code for task verify that we also use in the controller to validate.
Fixes #1320
Signed-off-by: Andreas Neumann aneumann@mesosphere.com