Compare real operator name, not prefix when checking for installed versions #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions Add unit tests to verify that. Add message if operator version install does not install new version Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
reviewed
Feb 11, 2020
pkg/kudoctl/util/kudo/kudo.go
Outdated
| @@ -216,10 +215,10 @@ func (c *Client) OperatorVersionsInstalled(operatorName, namespace string) ([]st | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| existingVersions := []string{} | |||
| existingVersions := make([]string, 0) | |||
There was a problem hiding this comment.
nit: I believe that syntax on the left is preferable unless you define a custom size.
There was a problem hiding this comment.
IntelliJ complained about it, referring to https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices
I changed it back for now
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
added a commit
that referenced
this pull request
Feb 13, 2020
…rsions (#1337) * Compare real operator name, not prefix when checking for installed versions * Unit tests to verify that. * Add message if operator version install does not install new version Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…rsions (#1337) * Compare real operator name, not prefix when checking for installed versions * Unit tests to verify that. * Add message if operator version install does not install new version Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to verify that.
Add message if operator version install does not install new version
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
Fixes #615