Plan verifier checks for mandatory deploy plan
#1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen-dog
force-pushed
the
ad/plan-verifier
branch
2 times, most recently
from
e824b49
to
76e9b62
Compare
Summary: - removed verifying that a plan is not referenced by any parameter. In the light of upcoming KEP-18 allowing triggering plans manually, some plans e.g. backup won be referenced by any parameter - added verifying that at least deploy plan exists in the operator Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
force-pushed
the
ad/plan-verifier
branch
from
76e9b62
to
4c53c28
Compare
ANeumann82
approved these changes
Feb 12, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Summary: - removed verifying that a plan is not referenced by any parameter. In the light of upcoming KEP-18 allowing triggering plans manually, some plans e.g. backup won be referenced by any parameter - added verifying that at least deploy plan exists in the operator Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Summary: - removed verifying that a plan is not referenced by any parameter. In the light of upcoming KEP-18 allowing triggering plans manually, some plans e.g. backup won be referenced by any parameter - added verifying that at least deploy plan exists in the operator Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
backupwon be referenced by any parameterdeployplan exists in the operator