Mark the status in the kep-template provisional #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarrick-mesosphere
requested review from
kensipe,
alenkacz,
gerred and
nfnt
I can see why we might mark it "implemented" if we consider this document itself a KEP, however the other fields are mostly fillers as well, so I think it makes sense to mark it provisional by default since a new KEP will always be provisional. Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com>
jbarrick-mesosphere
force-pushed
the
jbarrick-mesosphere-patch-1
branch
from
2f92042
to
ac97520
Compare
|
This was bugging me when I started writing my 4th KEP this week 😂 |
ANeumann82
approved these changes
Mar 3, 2020
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
I can see why we might mark it "implemented" if we consider this document itself a KEP, however the other fields are mostly fillers as well, so I think it makes sense to mark it provisional by default since a new KEP will always be provisional. Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see why we might mark it "implemented" if we consider this document itself a KEP, however the other fields are mostly fillers as well, so I think it makes sense to mark it provisional by default since a new KEP will always be provisional.