Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-20 part 2: trigger plans manually #1352

Merged
merged 13 commits into from
Mar 9, 2020
Merged

KEP-20 part 2: trigger plans manually #1352

merged 13 commits into from
Mar 9, 2020

Commits on Feb 25, 2020

  1. Converted Instance mutating webhook configuration 

    Summary:
- current `ValidationWebhookConfiguration` is replaced by `MutatingWebhookConfiguration` to allow instance admission webhook to set the `Spec.PlanExecution.PlanName`
- `Spec.PlanExecution.PlanName` is now not required anymore

Note:
- Instance CRD got updated
- breaking change: ValidationWebhookConfiguration from previous KUDO version (in case webhooks were used) has to be removed manually

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    995f025 View commit details
    Browse the repository at this point in the history

  2. Added new Instance.Spec.PlanExecution.UID field 

    so that when the same plan is re-triggered a new UID is generated and the controller can restart the plan.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    f66a280 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Implemented webhook rules around the deletion life-cycle phase of an … 

    …instance

additionally, instance controller now properly handles the cases where the webhooks are enabled and where they are disabled.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    78f68b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Minor fixes around cleanup life-cycle and plan termination 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f5e074c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Merge branch 'master' into ad/kep-20

    @zen-dog
    zen-dog committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    0a03bc7 View commit details
    Browse the repository at this point in the history

  2. Added cli support for triggering plans manually 

    new command `kudoctl plan trigger --name=<planNam> --instance=<instanceName>` is now available

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    0d8b0d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Fixing failing cli-install-uninstall test 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    b33f385 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. New tests and review feedback round one 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    86421a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ad/kep-20

    @zen-dog
    zen-dog committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    9981637 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. More PR review feedback 

    Proper namespace handling for CREATEd instances, robust detection of instances deletion life-cycle and logging improvements

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    dac7bed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ad/kep-20

    @zen-dog
    zen-dog committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    df37308 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Better comments and webhook documentation in test/README 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    4be346b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ad/kep-20

    @zen-dog
    zen-dog committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5e04f06 View commit details
    Browse the repository at this point in the history