Use a fork of code-generator. #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implementing a workaround as discussed in #1326 The logic in update-codegen.sh is changed to deal with the replace. We can just remove the replace once we upgrade to upstream code-generator which has the change, i.e. v0.18.0-alpha.1.0.20191220033320-6b257a9d6f46 or later. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
friendly ping |
ANeumann82
approved these changes
Feb 26, 2020
Co-Authored-By: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
porridge
force-pushed
the
use-codegen-fork
branch
from
b166aff
to
be30351
Compare
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
This is implementing a workaround as discussed in #1326 The logic in update-codegen.sh is changed to deal with the replace. We can just remove the replace once we upgrade to upstream code-generator which has the change, i.e. v0.18.0-alpha.1.0.20191220033320-6b257a9d6f46 or later. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com> Co-authored-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is implementing a workaround as discussed in
#1326
The logic in update-codegen.sh is changed to deal with the replace.
We can just remove the replace once we upgrade to upstream
code-generator which has the change, i.e.
v0.18.0-alpha.1.0.20191220033320-6b257a9d6f46 or later.
Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com