Verify that a rendered template is valid YAML #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix makefile if PATH does not include GOPATH/bin Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Feb 24, 2020
| ./hack/install-golangcilint.sh | ||
| endif | ||
| golangci-lint run | ||
| if [ ! -f ${GOPATH}/bin/golangci-lint ]; then ./hack/install-golangcilint.sh; fi |
There was a problem hiding this comment.
This assumes that golangci-lint is in $GOPATH/bin. If it has been installed elsewhere (e.g. by using the homebrew tap), this will run the script anyways. OTOH,hack/install-golangcilint.sh assumes that $GOPATH/bin is in $PATH 🤷♂
How about adding $GOPATH/bin to $PATH in hack/install-golangcilint.sh?
There was a problem hiding this comment.
Oh, that's too late :(
Because hack/install-golangcilint.sh doesn't run golangci-lint. The path manipulation would have to be done in the Makefile. Let's not change it in the Makefile and let's keep your approach.
There was a problem hiding this comment.
Yeah... It's messy :(
Co-Authored-By: Jan Schlicht <jan@d2iq.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
force-pushed
the
an/verify-valid-yaml-template
branch
from
a5e5874
to
524b029
Compare
This was referenced Mar 2, 2020
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Verify that a rendered template is valid YAML Co-Authored-By: Jan Schlicht <jan@d2iq.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix makefile if PATH does not include GOPATH/bin
Signed-off-by: Andreas Neumann aneumann@mesosphere.com