Change LastFinished to LastUpdated, timestamp every plan status change #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
force-pushed
the
plan_status_last_updated
branch
2 times, most recently
from
9607bd6
to
9a81c1e
Compare
ANeumann82
added
the
release/breaking-change
zen-dog
reviewed
Feb 28, 2020
…tus change Timestamp any changes to the status of a particular plan in order to help human operators with troubleshooting and debugging a KUDO Operator. This is a breaking change as it renames (repurposes) `LastFinished`. Update the CLI so that this is displayed for a given plan, if set. Signed-off-by: Nick Jones <nick@dischord.org>
yankcrime
force-pushed
the
plan_status_last_updated
branch
from
9a81c1e
to
ec96d1b
Compare
ANeumann82
approved these changes
Feb 28, 2020
kensipe
approved these changes
Feb 28, 2020
|
breaking change already on the label! nice! |
And it even get's automatically added to the Release-Draft in the correct section when the PR lands :) |
zen-dog
added a commit
that referenced
this pull request
Mar 2, 2020
Summary: this is a minor followup to #1365, which keeps the `UpdateInstanceStatus` method deterministic, making it testable. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…tus change (#1365) Timestamp any changes to the status of a particular plan in order to help human operators with troubleshooting and debugging a KUDO Operator. This is a breaking change as it renames (repurposes) `LastFinished`. Update the CLI so that this is displayed for a given plan, if set. Signed-off-by: Nick Jones <nick@dischord.org> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Summary: this is a minor followup to #1365, which keeps the `UpdateInstanceStatus` method deterministic, making it testable. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Timestamp any changes to the status of a particular plan in order to help human operators with troubleshooting and debugging a KUDO Operator.
Update the CLI so that this is displayed for a given plan, if set.
This is a breaking change as it renames (and repurposes)
LastFinished. For further context, see the discussion on Slack here.It's an alternative take on #1360
Fixes #1323