Remove the Instance finalizer only if the cleanup plan was successfully finished
#1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ully finished Summary: We check `IsFinished` and **not** `IsTerminal` status condition for the `cleanup` plan so that the finalizer is not removed in the `FatalError` case. This way a human operator has to intervene and we don't leave garbage in the cluster. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
ANeumann82
approved these changes
Feb 28, 2020
nfnt
approved these changes
Feb 28, 2020
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…ully finished (#1368) We check `IsFinished` and **not** `IsTerminal` status condition for the `cleanup` plan so that the finalizer is not removed in the `FatalError` case. This way a human operator has to intervene and we don't leave garbage in the cluster. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We check
IsFinishedand notIsTerminalstatus condition for thecleanupplan so that the finalizer is not removed in theFatalErrorcase. This way a human operator has to intervene and we don't leave garbage in the cluster.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com