Sort output of plan status and history commands #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
yankcrime
force-pushed
the
plan_status_order
branch
from
9afb022
to
995e005
Compare
yankcrime
force-pushed
the
plan_status_order
branch
from
995e005
to
4e1b222
Compare
ANeumann82
reviewed
Mar 1, 2020
yankcrime
force-pushed
the
plan_status_order
branch
2 times, most recently
from
cdd8ee2
to
ae9d3fd
Compare
ANeumann82
approved these changes
Mar 2, 2020
yankcrime
force-pushed
the
plan_status_order
branch
from
ae9d3fd
to
4522f08
Compare
yankcrime
changed the title
ANeumann82
reviewed
Mar 2, 2020
ANeumann82
approved these changes
Mar 2, 2020
yankcrime
force-pushed
the
plan_status_order
branch
from
4522f08
to
2870531
Compare
kensipe
requested changes
Mar 3, 2020
Alphabetise (by plan) the output of the plan status and history commands so that they're consistent with each run. This helps human operators when monitoring a deployment. Signed-off-by: Nick Jones <nick@dischord.org>
yankcrime
force-pushed
the
plan_status_order
branch
from
2870531
to
e287881
Compare
Include timestamps in output, and define more than one plan. Signed-off-by: Nick Jones <nick@dischord.org>
yankcrime
force-pushed
the
plan_status_order
branch
from
a1cc0e2
to
e1bcebb
Compare
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Sort output of plan status and plan history commands Alphabetise (by plan) the output of the plan status and history commands so that they're consistent with each run. This helps human operators when monitoring a deployment. Signed-off-by: Nick Jones <nick@dischord.org> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Alphabetise (by plan) the output of the plan status and history commands so that they're consistent with each run. This helps human operators when monitoring a deployment.
Fixes #1354