-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how docs are handled before and during release. #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen-dog
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but otherwise lgtm
kensipe
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice stuff!! I agree with zen-dog's request and added a few...
Also split the super-long lines into paragraphs for ease of diff viewing and reading, add some markup here and there, fix some typos and reword a couple of unclear sentences. Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com> Apply suggestions from code review Co-Authored-By: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
b3e862d
to
9faf92a
Compare
rebased and squashed dco violating suggestion commit |
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Document how docs are handled before and during release. Also split the super-long lines into paragraphs for ease of diff viewing and reading, add some markup here and there, fix some typos and reword a couple of unclear sentences. Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io> Co-authored-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Let's try using a
next-release
branch for docs.Also split the super-long lines into paragraphs for ease of diff viewing
and reading, add some markup here and there, fix some typos and reword a
couple of unclear sentences.
Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com