Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how docs are handled before and during release. #1388

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

porridge
Copy link
Member

@porridge porridge commented Mar 4, 2020

What this PR does / why we need it:

Let's try using a next-release branch for docs.

Also split the super-long lines into paragraphs for ease of diff viewing
and reading, add some markup here and there, fix some typos and reword a
couple of unclear sentences.

Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but otherwise lgtm

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff!! I agree with zen-dog's request and added a few...

RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
porridge and others added 2 commits March 5, 2020 13:05
Also split the super-long lines into paragraphs for ease of diff viewing
and reading, add some markup here and there, fix some typos and reword a
couple of unclear sentences.

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>

Apply suggestions from code review

Co-Authored-By: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe
Copy link
Member

kensipe commented Mar 5, 2020

rebased and squashed dco violating suggestion commit

@kensipe kensipe merged commit 9dea5fd into master Mar 5, 2020
@kensipe kensipe deleted the release-and-docs branch March 5, 2020 21:41
runyontr pushed a commit that referenced this pull request Mar 11, 2020
* Document how docs are handled before and during release.

Also split the super-long lines into paragraphs for ease of diff viewing
and reading, add some markup here and there, fix some typos and reword a
couple of unclear sentences.


Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Co-authored-by: Ken Sipe <kensipe@gmail.com>

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants