Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager no longer is a deployment #1399

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

anthonydahanne
Copy link
Contributor

What this PR does / why we need it:
Fix the documentation

Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-Authored-By: Zain Malik <zmalikshxil@gmail.com>
Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
@kensipe kensipe merged commit f6b8509 into kudobuilder:master Mar 10, 2020
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Co-Authored-By: Zain Malik <zmalikshxil@gmail.com>
Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>

Signed-off-by: Thomas Runyon <runyontr@gmail.com>
zen-dog pushed a commit that referenced this pull request Mar 11, 2020
Co-Authored-By: Zain Malik <zmalikshxil@gmail.com>
Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants