Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention template filename in error message. #1401

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

porridge
Copy link
Member

@porridge porridge commented Mar 9, 2020

What this PR does / why we need it:

This example shows why the current message is not verbose enough.

Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚢

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 6bd083d into master Mar 9, 2020
@kensipe kensipe deleted the error-with-filename branch March 9, 2020 22:28
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants