-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancer and HealthUtil now differentiate between fatal and transient errors #1427
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c9b767
Introducing transient errors into the enhancer
zen-dog 32dcf2c
Enhancer now uses `engine.ErrFatalExecution` to mark fatal errors
zen-dog cb11fde
Making tests green again
zen-dog b1667fe
HealthUtil now also uses the `ErrFatalExecution` for health errors th…
zen-dog 0b253e2
Minor logging improvement and an extra test case for a transient error
zen-dog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ package task | |
import ( | ||
"context" | ||
"encoding/json" | ||
"errors" | ||
"fmt" | ||
"log" | ||
|
||
|
@@ -18,6 +19,7 @@ import ( | |
"sigs.k8s.io/controller-runtime/pkg/client" | ||
|
||
"github.com/kudobuilder/kudo/pkg/apis/kudo/v1beta1" | ||
"github.com/kudobuilder/kudo/pkg/engine" | ||
"github.com/kudobuilder/kudo/pkg/engine/health" | ||
"github.com/kudobuilder/kudo/pkg/engine/resource" | ||
"github.com/kudobuilder/kudo/pkg/util/kudo" | ||
|
@@ -46,7 +48,7 @@ func (at ApplyTask) Run(ctx Context) (bool, error) { | |
// 2. - Enhance them with metadata - | ||
enhanced, err := enhance(rendered, ctx.Meta, ctx.Enhancer) | ||
if err != nil { | ||
return false, fatalExecutionError(err, taskEnhancementError, ctx.Meta) | ||
return false, err | ||
} | ||
|
||
// 3. - Apply them using the client - | ||
|
@@ -58,8 +60,8 @@ func (at ApplyTask) Run(ctx Context) (bool, error) { | |
// 4. - Check health for all resources - | ||
err = isHealthy(applied) | ||
if err != nil { | ||
if fatal := isTerminallyFailed(applied); fatal != nil { | ||
return false, fatalExecutionError(fatal, failedTerminalState, ctx.Meta) | ||
if errors.Is(err, engine.ErrFatalExecution) { | ||
return false, fatalExecutionError(err, failedTerminalState, ctx.Meta) | ||
} | ||
// an error during a health check is not treated task execution error | ||
log.Printf("TaskExecution: %v", err) | ||
|
@@ -239,16 +241,6 @@ func isHealthy(ro []runtime.Object) error { | |
return nil | ||
} | ||
|
||
func isTerminallyFailed(ro []runtime.Object) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Arguably this is a better separation of concerns: determining whether a resource health error is terminal is better left to the |
||
for _, r := range ro { | ||
if failed, msg := health.IsTerminallyFailed(r); failed { | ||
key, _ := client.ObjectKeyFromObject(r) | ||
return fmt.Errorf("object %s/%s has failed: %s", key.Namespace, key.Name, msg) | ||
} | ||
} | ||
return nil | ||
} | ||
|
||
// copy from k8s.io/kubectl@v0.16.6/pkg/util/apply.go, with adjustments | ||
// GetOriginalConfiguration retrieves the original configuration of the object | ||
// from the annotation. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We return a
type engine.ExecutionError struct
if we encountered a fatal health error.