Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to release process #1428

Merged
merged 2 commits into from
Mar 18, 2020
Merged

update to release process #1428

merged 2 commits into from
Mar 18, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Mar 17, 2020

Updates for a number of things:

  1. Moved release preconditions to a precondition block.
  2. Ignore the krew file kudo.yaml which is generated (it shouldn't dirty the build)
  3. Removing author from change logs... this is often a group effort. the author is captured as a contributor.
  4. there is no release blog... we need to have a blog for releases but it is not the release managers responsibility IMO. There is a note added to encourage it.

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how we could increase the chance of actually creating a blog post regularly.

Do you think it would it make sense to add a step for the release engineer to start a blank, draft blog PR for the next release after finishing this one? This would in turn allow us to point contributors at it from our pull request template in order to encourage contributions to the upcoming release's blog post as we go along?

.gitignore Outdated
@@ -6,6 +6,8 @@ hack/controller-gen
test/.git-credentials
reports/
config/manager_image_patch.yaml-e
# created with krew gen scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# created with krew gen scripts
# created by /hack/generate_krew.sh during release

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe
Copy link
Member Author

kensipe commented Mar 18, 2020

@porridge after some thought... I'm not sure how to encourage a blog action here... it is noted... repeating it doesn't make sense. A task of creating blank fill in the blank that will be opened for a long time doesn't really do much IMO other than give the release manager another task. If a blog is to done for a release which is focused on highlighting a new feature (instead of just repeating the release notes) then it seems like a project task needs to be created and someone needs to be assigned to it. I would rather have the release manager create a blog task than a PR with a blank or templated page.

We should talk about this as a team and make an update based on outcome instead of holding up this PR.

@kensipe kensipe merged commit 5c47566 into master Mar 18, 2020
@kensipe kensipe deleted the ken/release-update branch March 18, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants