Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Controller-gen Version #1434

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Check Controller-gen Version #1434

merged 2 commits into from
Mar 26, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Mar 20, 2020

Previously there was a check to see if controller-gen was missing, then it installed the version associated with controller tools. Now it actually checks to see if this is the correct version otherwise gets the correct version.
I looked at doing the same for go-bindata but it's version output is challenging and likely needs awk. This makes controller-gen much better which is the more likely change.

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate question is whether we should maybe install tools we need into a private $GOBIN to prevent thrashing back-and-forth if a different project happens to require another version... 🤔
But this is great!

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what @porridge said, otherwise LGTM.

Co-Authored-By: Marcin Owsiany <mowsiany@D2iQ.com>
@kensipe kensipe merged commit 9ed8b1e into master Mar 26, 2020
@kensipe kensipe deleted the ken/cont-gen-versioning branch March 26, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants