Use sigs.k8s.io/yaml rather than pkg.in/yaml.v2. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Mar 25, 2020
|
Also, I'd like to see a test for the #1437 |
ANeumann82
approved these changes
Mar 25, 2020
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
|
Thanks for the quick reviews. Test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Turns out that
yaml.v2unmarshals maps intomap[interface{}]interface{}ratherthan try to insist on a most narrow possible key type (i.e. string). Such values
are then rejected by sigs.k8s.io/yaml.Marshal that
WrapParamValueuses,because it does a conversion to JSON first, and JSON does not support
non-string keys.
It seems like
yaml.v3works better in that regard. However comments on theaforementioned issue seem to imply that it's still not all rosy.
Moreover, using the same package for unmarshalling as we do for marshalling
seems like a more stable choice long-term.
This also adds some vlog statements and tidies up go.mod.
Fixes #1437
Fixes #1463