Plan Update and Trigger with Wait

[kensipe]

--wait and --wait-time added for plan update and plan trigger

Signed-off-by: Ken Sipe kensipe@gmail.com

[ANeumann82]

lgtm.

I wouldn't mind having the WaitTime added to the plan status --wait command as well, so we have a unified set of arguments.

[zen-dog]

I would like to postpone this PR until we have the instance admission controller (IAC) active by default. The problem is that in the absence of IAC, IC will effectively ignore updates if there is already a plan in progress. This will lead to WaitForInstance method not seeing any UID change and so the command will hang, potentially forever. This behavior was always there but this PR makes it easy to run into this issue.

[kensipe]

@zen-dog while the story can be improved... we can doc the feature until the IAC is in place... what is the timeframe of IAC?

[kensipe]

the rejection seems unwarranted... the "will hang, potentially forever" seems scary but it is not. This is a known situation.. and is on the client side. no harm will come from it and the "hang" if invoked can be cancelled with ctrl+c break... under this scenario it would act like a kubectl --watch which any regular user of kube would now how to break.

[zen-dog]

I don't believe many users are aware of all existing pitfalls that arise without active IAC in the presence of multiple plans. And I'd rather not expose users to them via a CLI option. The ETA for making IAC required is 0.13. That being said, feel free to merge anway if you feel strongly about needing this feature.

¯_(ツ)_/¯

[kensipe]

rebased to the latest... we also now have IAC as default on.