Activating instance admission controller for the e2e tests #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: when initializing KUDO manager for the e2e tests we now use the `--webhook InstanceValidation --unsafe-self-signed-webhook-ca` options that activate the instance admission controller (IAC) using the self-signed webhook CA bundle. We must ensure that KUDO manager runs before we begin executing test steps, otherwise, IAC `MutatingWebhookConfiguration` will fail `CREATE` and `UPDATE` requests to the `Instance` resources if the webhook server is not up and running. To achieve this, I added first step to all e2e steps ensuring the `kudo-controller-manager` pod is `Running`. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
requested review from
alenkacz,
gerred,
kensipe and
nfnt
as code owners
zen-dog
commented
Apr 17, 2020
| @@ -1,5 +1,5 @@ | |||
| apiVersion: kudo.dev/v1beta1 | |||
| kind: TestStep | |||
| commands: | |||
| - command: kubectl kudo update --instance feature-operator-instance -p enable_cm=false | |||
| namespaced: true | |||
| - command: kubectl kudo update --instance feature-operator-instance -p enable_cm=true | |||
There was a problem hiding this comment.
This diff is confusing: I had to insert the 00-assert.yaml at the beginning and so all other step files had their numbers increased and now it looks like there was a change here, but there wasn't.
zen-dog
commented
Apr 17, 2020
| @@ -13,7 +13,7 @@ docker build . \ | |||
| -t "kudobuilder/controller:$VERSION" | |||
|
|
|||
| # Generate the kudo.yaml that is used to install KUDO while running e2e-test | |||
| ./bin/kubectl-kudo init --dry-run --output yaml --kudo-image kudobuilder/controller:$VERSION \ | |||
| ./bin/kubectl-kudo init --webhook InstanceValidation --unsafe-self-signed-webhook-ca --dry-run --output yaml --kudo-image kudobuilder/controller:$VERSION \ | |||
There was a problem hiding this comment.
This activates the IAC
zen-dog
commented
Apr 17, 2020
| @@ -0,0 +1,12 @@ | |||
| apiVersion: kudo.dev/v1beta1 | |||
There was a problem hiding this comment.
And this is waiting for KUDO manager to come up before every test
kensipe
approved these changes
Apr 17, 2020
| kind: Deployment | ||
| metadata: | ||
| name: nginx-deployment | ||
| phase: Running |
ANeumann82
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
when initializing KUDO manager for the e2e tests we now use the
--webhook InstanceValidation --unsafe-self-signed-webhook-caoptions that activate the instance admission controller (IAC) using the self-signed webhook CA bundle.We must ensure that KUDO manager runs before we begin executing test steps, otherwise, IAC
MutatingWebhookConfigurationwill failCREATEandUPDATErequests to theInstanceresources if the webhook server is not up and running. To achieve this, I added first step to all e2e steps ensuring thekudo-controller-managerpod isRunning.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com