Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dispatch 1.1.0-beta1 #1475

Merged
merged 2 commits into from
May 5, 2020
Merged

Use dispatch 1.1.0-beta1 #1475

merged 2 commits into from
May 5, 2020

Conversation

porridge
Copy link
Member

@porridge porridge commented Apr 21, 2020

What this PR does / why we need it:

Second stab at dispatch.

  • rename Dispatchfile.cue to Dispatchfileand rewrite it in starlark
  • run lint and integration-test
  • add resource reservations and limits
  • run tests on every push to mimic CircleCI

With this setup:

  • lint on dispatch finishes about 2 minutes later than on CircleCI (most likely due to lack of caching support)
  • integration-test on dispatch finishes about 40 seconds earlier than on CircleCI (cause unknown)
  • e2e-test is not yet running on dispatch, more work needed
  • the two jobs that do run on dispatch are not marked as required, purely an experiment at this stage

This is the first step towards #1054

README.md Outdated Show resolved Hide resolved
@porridge
Copy link
Member Author

/test

@porridge
Copy link
Member Author

/test

4 similar comments
@porridge
Copy link
Member Author

/test

@porridge
Copy link
Member Author

/test

@porridge
Copy link
Member Author

/test

@porridge
Copy link
Member Author

/test

- rename Dispatchfile.cue to Dispatchfile
- run lint and integration-tests.
- rewrite in starlark
- add resource reservations and limits

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
@porridge porridge changed the title Dummy change to trigger dispatch Use dispatch 1.1.0-beta1 Apr 22, 2020
@porridge porridge marked this pull request as ready for review April 22, 2020 07:59
@porridge porridge merged commit 1e7adc9 into master May 5, 2020
@porridge porridge deleted the porridge/dummy branch May 5, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants