-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dispatch 1.1.0-beta1 #1475
Merged
Merged
Use dispatch 1.1.0-beta1 #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
commented
Apr 21, 2020
/test |
dab1fcc
to
c5e5c5c
Compare
/test |
4 similar comments
/test |
/test |
/test |
/test |
- rename Dispatchfile.cue to Dispatchfile - run lint and integration-tests. - rewrite in starlark - add resource reservations and limits Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
c975e8d
to
2cc8653
Compare
ANeumann82
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Second stab at dispatch.
Dispatchfile.cue
toDispatchfile
and rewrite it in starlarklint
andintegration-test
With this setup:
lint
on dispatch finishes about 2 minutes later than on CircleCI (most likely due to lack of caching support)integration-test
on dispatch finishes about 40 seconds earlier than on CircleCI (cause unknown)e2e-test
is not yet running on dispatch, more work neededThis is the first step towards #1054