Add possibility for pipe-tasks to pipe env-files

[zen-dog]

Summary:
When creating ConfigMaps or Secrets k8s allows for taking an env-file using the --from-env-file option. Env-files contain a list of environment variables.

These syntax rules apply:

• Each line in an env file has to be in VAR=VAL format.
• Lines beginning with # (i.e. comments) are ignored.
• Blank lines are ignored.
• There is no special handling of quotation marks (i.e. they will be part of the ConfigMap value))

New pipe-task envFile field can be used instead of file to signal that the pipe-file should be treated as an env-file:

spec:
 pipe:
   - envFile: /tmp/foo.env
     kind: ConfigMap
     key: foo

Note, that either file or envFile can be used but not both.

For more information on env-files see k8s documentation

Fixes: #1394

Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com

[ANeumann82]

Two small nits, other than that it looks good

[nfnt]

LGTM!

[wombat]

@zen-dog I am running into this error: failed to build task deploy.main.install-test.install-test: task validation error: pipe file is empty: { ConfigMap dotEnv}"

My Task:

- name: install-test
    kind: Pipe
    spec:
      pod: install-test.yaml
      pipe:
        - envFile: /tmp/foo.env
          kind: ConfigMap
          key: dotEnv

I already checked that the pod is mounting the /tmp folder but it does not even launch this pod so it can´t be a missing file.

[zen-dog]

It seems you're simply using an outdated kudo version which doesn't have envFile support.

[wombat]

Well I tried with the kudo terraform provider and configured the kudo version to be 0.13.0-rc1 - BUT I guess because the terraform provider uses an older kudo version the validation might fail there?

[zen-dog]

I'm not sure, @runyontr do you know more?

[wombat]

I also uninstalled my brew cask and manually installed the 0.13.0-rc1 - after running kudo manually without terraform I got the same error.

[runyontr]

Can you try a key with all lowercases?

[wombat]

@runyontr unfortunately its the same result

[wombat]

I just noticed that when I describe the instance I can see the following message:

  Warning  UnknownTaskKind  10s   instance-controller  Error during execution: default/test fatal error:  failed to build task deploy.main.install-test.install-test: task validation error: pipe file is empty: { ConfigMap dotenv}

I am confused about the UnknownTaskKind - this supports the theory of @zen-dog - here is my version output:

kubectl kudo version                                                                                                                                                                                                                                                                                            
KUDO Version: version.Info{GitVersion:"0.13.0-rc1", GitCommit:"89fe2dc3", BuildDate:"2020-05-08T16:06:23Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}

[runyontr]

It looks like that error is returned regardless of the reason the error happened. So even though the issue was some configuration with the task, the logic here:

https://github.com/kudobuilder/kudo/blob/master/pkg/engine/workflow/engine.go#L155-L165

only returns the value here:

https://github.com/kudobuilder/kudo/blob/master/pkg/engine/workflow/engine.go#L22

[zen-dog]

The UnknownTaskKind is confusing, but the error message is pretty descriptive. And the v0.13.0-rc1 version has the env-file support as shown in this test