Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use namespace specified by current config context #1489

Merged
merged 1 commit into from
May 8, 2020

Conversation

yankcrime
Copy link
Member

What this PR does / why we need it:

Use the namespace defined in the current context, if it's been set.

Otherwise default to 'default'.

Signed-off-by: Nick Jones nick@dischord.org

Fixes #1477

Use the namespace defined in the current context, if it's been set.
Otherwise default to 'default'.

Signed-off-by: Nick Jones <nick@dischord.org>
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably mention that in the release notes, as it changes default behavior.

Copy link
Member

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@zen-dog zen-dog merged commit 8ae008e into master May 8, 2020
@zen-dog zen-dog deleted the kudo_ns_context branch May 8, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl kudo install doesn't use the namespace set in the context
5 participants