Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-31: Namespace Management #1496

Merged
merged 8 commits into from
May 13, 2020
Merged

KEP-31: Namespace Management #1496

merged 8 commits into from
May 13, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented May 6, 2020

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@ANeumann82
Copy link
Member

Nice KEP! I'd really like to already see a "User Stories" section where we can describe some expectations already - and then we can decide if something is reasonable or not.

I have at least a couple in mind:

  • Meta-Operator that wants to separate different parts into different namespaces. Namespaces could be prefixed with the root-operators "base" namespace.
  • Meta-Operator with dependencies: Same as above, but parts of the functionality is already extracted into separate operators which are included as dependencies
  • Custom Application operators in a single company: Multiple Operators that are only used in a restricted and very opinionated environment: All operators will have to install their monitoring parts into a namespace "monitoring".

Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for all the details of namespace management.

I added a few comments that already reflect my preference to not create namespaces in KUDO. In my opinion creating and deleting namespaces is a responsibility of the cluster admins that know best about the topology of different teams and projects in the cluster.

keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
@zen-dog zen-dog changed the title KEP 31 Namespace Management KEP-31: Namespace Management May 11, 2020
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, however, I'd like for us to be explicit about namespace creation (see my comment about the rules)

keps/0031-namespace-management.md Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff @kensipe !
LGTM as the first version of KEP and we might add more proposals later or go more in details in some alternatives

@kensipe
Copy link
Member Author

kensipe commented May 11, 2020

Some added context for multi-namespace support:

. Istio has a component called istio-cni that has system-cluster-critical priorityclass. As of kubernetes 1.16, such deployment can only happen in kube-system namespace. Hence, we need an ability to deploy components in multiple namespaces

keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits and typos, one addition/clarification to the rules

keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Outdated Show resolved Hide resolved
keps/0031-namespace-management.md Show resolved Hide resolved
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammar nits but otherwise 🚢

kensipe and others added 2 commits May 13, 2020 11:15
Co-authored-by: Andreas Neumann <aneumann@mesosphere.com>
Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe kensipe merged commit 010b94f into master May 13, 2020
@kensipe kensipe deleted the ken/kep-ns branch May 13, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants