Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed --webhook option #1497

Merged
merged 27 commits into from
May 19, 2020
Merged

Removed --webhook option #1497

merged 27 commits into from
May 19, 2020

Commits on Apr 27, 2020

  1. Removed --webhook option 

    Summary:
Now that KUDO moves towards a better support of multiple plans (e.g. `kudoctl plan trigger` command), the existing instance admission webhook becomes necessary to guarantee the plan execution consistency. More on KUDO [admission controller](https://kudo.dev/docs/developing-operators/plans.html#admission-controllers) in the documentation.

This PR removes the `--webhook` option and thus makes the instance admission webhook required. This is a breaking change since the users will have to either have [cert-manager](https://cert-manager.io/) installed or use the `--unsafe-self-signed-webhook-ca` option when initializing KUDO. For existing installations one would need to run [kudo init](https://kudo.dev/docs/cli.html#examples) to create missing secret/webhook configuration.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    dfdc48b View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Merge branch 'master' into ad/required-webhook

    @zen-dog
    zen-dog committed May 5, 2020
    Configuration menu
    Copy the full SHA
    18830cf View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Merge branch 'master' into ad/required-webhook

    @zen-dog
    zen-dog committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9fa17e3 View commit details
    Browse the repository at this point in the history

  2. Making integration tests green 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8c3ac8b View commit details
    Browse the repository at this point in the history

  3. Making linter happy 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 7, 2020
    Configuration menu
    Copy the full SHA
    646b0ad View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Temporary enabling skipDelete: true option for e2e tests 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    f7aed1b View commit details
    Browse the repository at this point in the history

  2. Removed a debugging remnant 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    9f3f81b View commit details
    Browse the repository at this point in the history

  3. Making KUDO_CERT_DIR default x-platform 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    adbddac View commit details
    Browse the repository at this point in the history

  4. Space at the end of kudo-e2e-test.yaml 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    fe0d307 View commit details
    Browse the repository at this point in the history

  5. Review feedback part one 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    8d05566 View commit details
    Browse the repository at this point in the history

  6. Fixed default KUDO_CERT_DIR path 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    374db1f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ad/required-webhook

    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    e7bfb4b View commit details
    Browse the repository at this point in the history

  8. Removed skipDelete: true e2e option 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    3f1d82d View commit details
    Browse the repository at this point in the history

  9. Revert "Removed skipDelete: true e2e option" 

    This reverts commit 3f1d82d.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 8, 2020
    Configuration menu
    Copy the full SHA
    8f11643 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Temporary switch to patched kuttl version 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    2fe4ee2 View commit details
    Browse the repository at this point in the history

  2. Trying to get e2e operator tests logs 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    f05df7c View commit details
    Browse the repository at this point in the history

  3. and proper reports path 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    fb081b2 View commit details
    Browse the repository at this point in the history

  4. and moving logs one level up 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    b33fd6d View commit details
    Browse the repository at this point in the history

  5. and with setting the proper --artifacts-dir /tmp/kudo-e2e-test 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    7d9641d View commit details
    Browse the repository at this point in the history

  6. and with skipDelete: true for operator tests 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    7362dd9 View commit details
    Browse the repository at this point in the history

  7. run operators e2e tests agains operators/dev branch 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 11, 2020
    Configuration menu
    Copy the full SHA
    206d7e9 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Merge branch 'master' into ad/required-webhook

    @zen-dog
    zen-dog committed May 18, 2020
    Configuration menu
    Copy the full SHA
    f91b405 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Fixed TestIntegInitForCRDs 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 19, 2020
    Configuration menu
    Copy the full SHA
    58d99e8 View commit details
    Browse the repository at this point in the history

  2. Removed crdDir and manifestDirs from the e2e test configuration 

    as they are generated by `kudo init` or not needed anymore

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 19, 2020
    Configuration menu
    Copy the full SHA
    4123776 View commit details
    Browse the repository at this point in the history

  3. Running operators tests with the new kudo-test.yaml.tmpl 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 19, 2020
    Configuration menu
    Copy the full SHA
    6b1ffd0 View commit details
    Browse the repository at this point in the history

  4. and with proper sed-ing 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 19, 2020
    Configuration menu
    Copy the full SHA
    03e45b7 View commit details
    Browse the repository at this point in the history

  5. going back to operators master branch 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed May 19, 2020
    Configuration menu
    Copy the full SHA
    14dca5f View commit details
    Browse the repository at this point in the history