KUDO init --upgrade #1505
Merged
KUDO init --upgrade #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
renamed validate option to verify Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> # Conflicts: # hack/run-e2e-tests.sh # pkg/kudoctl/cmd/init.go # pkg/kudoctl/kudoinit/manager/manager.go # pkg/kudoctl/kudoinit/options.go
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> # Conflicts: # hack/run-e2e-tests.sh # pkg/kudoctl/cmd/init.go # pkg/kudoctl/cmd/init_integration_test.go # pkg/kudoctl/kudoinit/manager/manager.go # pkg/kudoctl/kudoinit/options.go # pkg/kudoctl/kudoinit/prereq/namespace_test.go # pkg/kudoctl/kudoinit/prereq/serviceaccount_test.go # pkg/kudoctl/kudoinit/prereq/webhook_test.go
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> # Conflicts: # hack/run-e2e-tests.sh # pkg/kudoctl/cmd/init.go # pkg/kudoctl/cmd/init_test.go # pkg/kudoctl/kudoinit/prereq/webhook.go # pkg/kudoctl/kudoinit/setup/setup.go
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
# Conflicts: # pkg/kudoctl/kudoinit/prereq/webhook.go
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
reviewed
Jun 23, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
zen-dog
reviewed
Jun 29, 2020
zen-dog
reviewed
Jun 29, 2020
Added more debug output Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> # Conflicts: # pkg/kudoctl/kudoinit/crd/crds.go # pkg/kudoctl/kudoinit/manager/manager.go
runyontr
reviewed
Jul 1, 2020
| } | ||
|
|
||
| // Upgrade an existing KUDO installation | ||
| func (i *Installer) Upgrade(client *kube.Client) error { |
There was a problem hiding this comment.
Could we use a Patch instead of deleting/re-installing:
https://github.com/kubernetes/client-go/blob/master/kubernetes/typed/apps/v1/statefulset.go#L50
There was a problem hiding this comment.
We could - We actually patch the CRDs, but for the Service and statefulset this would involve either manually creating the patch, or saving the old version in annotations, similar to TaskApply. Delete/Recreate is a lot easier. We may come back to patching later on though.
|
Holding the merge until after KUDO v0.15.0 is released |
ANeumann82
added
release/breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
kudo init --upgradeto upgrade an existing KUDO installationAdd
kudo init --verifyto check the state of an existing KUDO installationkudo initwithout any flag will now complain if it is run on a cluster that has an existing KUDO installation (to prevent accidental upgrades)Added migration framework - There are no actual migrations in there at the moment, but the upgrade path is there to add them when we need them
Added basic upgrade test in the e2e section - This might need some update if we're going to add more tests here, as we probably want a fresh kind-cluster for each test. They're probably going to be the most expensive tests we do
The new branch, because refactoring was extracted from the old #1467 Also fixes DCO issues from the old branch.
Fixes #891