Lint files with 'integration' build flag

[nfnt]

What this PR does / why we need it:
golangci-lint has to be instructed to not skip code that has build tags. By adding integration to the build-tags property, we ensure that integration tests are linted.

[ANeumann82]

Nice find :)

[kensipe]

not sure if we have a flaky test... :(

=== RUN   TestRestartController
 
2020/05/12 08:55:06 Given an existing instance 'foo-instance' and operator 'foo-operator'
 
2020/05/12 08:55:06 And a deploy plan that was already run
 
Instance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not found    TestRestartController: instance_controller_test.go:96: 
 
        	Error Trace:	instance_controller_test.go:96
 
        	Error:      	Condition never satisfied
 
        	Test:       	TestRestartController
 
2020/05/12 08:55:11 When we stop the manager
 
2020/05/12 08:55:11 And update the instance parameter value
 
    TestRestartController: instance_controller_test.go:104: 
 
        	Error Trace:	instance_controller_test.go:104
 
        	Error:      	Received unexpected error:
 
        	            	Instance.kudo.dev "foo-instance" not found
 
        	Test:       	TestRestartController
 
    TestRestartController: instance_controller_test.go:106: 
 
        	Error Trace:	instance_controller_test.go:106
 
        	Error:      	Received unexpected error:
 
        	            	Operation cannot be fulfilled on instances.kudo.dev "foo-instance": StorageError: invalid object, Code: 4, Key: /registry/kudo.dev/instances/default/foo-instance, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 8c6d887b-aa54-4bf4-b72c-d424f80eebbf, UID in object meta: 
 
        	Test:       	TestRestartController
 
2020/05/12 08:55:11 And restart the manager again
 
2020/05/12 08:55:11 Then an update plan should be triggered instead of deploy plan
 
Instance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not foundInstance.kudo.dev "foo-instance" not found    TestRestartController: instance_controller_test.go:112: 
 
        	Error Trace:	instance_controller_test.go:112
 
        	Error:      	Condition never satisfied
 
        	Test:       	TestRestartController
 
--- FAIL: TestRestartController (10.10s)
 

restarted test

[nfnt]

@kensipe These are errors from asserting the resources are deleted. It's not a flake, but also very unlikely that it's uncovering a bug in KUDO. I'll check what needs to be done to assert resource deletion while also making sure that only existing resources are deleted.

[nfnt]

I'll have to give up on init_integration_test.go for now. There are some dependencies on the order of the resources to be deleted. Furthermore, it seems that ignoring these error in the past resulted in test cases depending on resources created by prior test cases. As least that's how I interpret the current test results. The whole test suite needs to be refactored to ensure that resources are use in the way they're supposed to be used. Fixed.

[zen-dog]

Nice work! 🚢