Add KudoOperator task types
#1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help parallelize upcoming work on KEP-29. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
commented
May 12, 2020
| Plans map[string]Plan `json:"plans,omitempty"` | ||
|
|
||
| // ConnectionString defines a templated string that can be used to connect to an instance of the Operator. | ||
| // +optional | ||
| ConnectionString string `json:"connectionString,omitempty"` | ||
|
|
||
| // Dependencies a list of all dependencies of the operator. | ||
| Dependencies []OperatorDependency `json:"dependencies,omitempty"` |
There was a problem hiding this comment.
Removed an old remnant
zen-dog
commented
May 12, 2020
| @@ -102,7 +102,7 @@ The `zookeeper-operator` task specification is equivalent to `kudo install zooke | |||
| ```yaml | |||
| tasks: | |||
| - name: demo | |||
| kind: Operator | |||
| kind: KudoOperator | |||
There was a problem hiding this comment.
I ended up renaming s/Operator/KudoOperator thinking about other operators we could deploy in the future after we have a mechanism in place. But this is up for discussion.
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
ANeumann82
reviewed
May 13, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
force-pushed
the
ad/operator-task-types
branch
from
07eaa28
to
eb808b6
Compare
ANeumann82
approved these changes
May 13, 2020
nfnt
requested changes
May 14, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
nfnt
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help parallelize upcoming work on KEP-29.
Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com
Fixes: #1509