Uncached client for instance admission webhook #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen-dog
force-pushed
the
ad/uncached-webhook-client
branch
from
dce8cb6
to
2fa9135
Compare
Summary: we've seen an increased flakiness lately with some ITs e.g. `terminal-failed-job` and `dependencies-hash` where a previously created `OperatorVersion` is not observed by the instance admission webhook. This PR switches to an uncached client for the IAW which should alleviate the problem. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
force-pushed
the
ad/uncached-webhook-client
branch
from
2fa9135
to
c6eaa8b
Compare
ANeumann82
approved these changes
May 13, 2020
kensipe
approved these changes
May 13, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
we've seen increased flakiness lately with some ITs e.g.
terminal-failed-jobanddependencies-hashwhere a previously createdOperatorVersionis not observed by the instance admission webhook. This PR switches to an uncached client for the IAW which should alleviate the problem.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com