Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kubernetes Clientset to kudo.Client #1528

Merged
merged 9 commits into from
May 18, 2020
Merged

Adding Kubernetes Clientset to kudo.Client #1528

merged 9 commits into from
May 18, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented May 15, 2020

This is needed for the namespace creation and for diagnostics. As some discussion it was taken under advisement to separate this into its own PR and reducing the namespace PR to just what is needed for namespace... resulting in this PR which is narrowed to the adding kubernetes clientset to our kudo.Client.

Fixes #

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit but otherwise lgtm 🚢

pkg/kudoctl/util/kudo/kudo.go Outdated Show resolved Hide resolved
Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
@kensipe kensipe merged commit 87b7966 into master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants