Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tool Gen version Info to output for CI #1530

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented May 15, 2020

I had a recent fight with CI over "verifying" codegen. This was due to a homebrew update of go-bindata which was out of sync with the CI env. It was more challenging than it needed to be and this information in our CI logs would have made it easy.

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 474c4e3 into master May 18, 2020
@kensipe kensipe deleted the ken/ci-logs-need-versions branch May 18, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants