Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes dependencies to 1.18.3 #1537

Merged
merged 6 commits into from Jun 30, 2020
Merged

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented May 25, 2020

What this PR does / why we need it:
This updated the Kubernetes APIs to 1.18.3. This update contains some breaking changes, as many calls have been made async ready (by taking a context.Context parameter) and consistent (by having options everywhere).

TODO:

Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe kensipe added this to the 0.15.0 milestone Jun 23, 2020
@kensipe kensipe changed the base branch from master to main June 24, 2020 00:44
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>

# Conflicts:
#	go.mod
#	go.sum
#	pkg/kudoctl/cmd/testdata/deploy-kudo-webhook.yaml.golden
#	pkg/kudoctl/kudoinit/crd/bindata.go
#	pkg/kudoctl/kudoinit/prereq/webhook.go
#	pkg/kudoctl/util/kudo/kudo.go
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@gerred
Copy link
Member

gerred commented Jun 29, 2020

it's weird that circle isn't running.

oh, I bet it's our branch update. changes look good but we'll need to sort out that part.

@ANeumann82
Copy link
Member

This shouldn't be merged yet - It references an unreleased kuttl version, we need to wait for kuttl 0.5.0 release

Signed-off-by: Jan Schlicht <jan@d2iq.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 93b8220 into main Jun 30, 2020
@kensipe kensipe deleted the nfnt/bump-k8s-api-to-1.18 branch June 30, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants