Do not set ownership for x-namespaced resources #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `controller-runtime` already does the [namespace checking](https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/controller/controllerutil/controllerutil.go#L144) which was presumably not always the case (and why we had to implement our own) Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
changed the title
setControllerReference methodsetControllerReference method
porridge
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
It is very interesting that @alenkacz added this method in the very same PR where she bumped KUDO to controller-runtime v0.4.0 which is exactly the release where a nearly identical check was added to the upstream SetControllerReference.
Do they somehow differ in a way that I'm not seeing?
nfnt
approved these changes
Jun 4, 2020
ANeumann82
approved these changes
Jun 4, 2020
|
@zen-dog @porridge this is the difference 36db82b#diff-3bd375e61436a5abcf9038292ccdafa3R133 |
zen-dog
added
the
release/breaking-change
zen-dog
changed the title
setControllerReference method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we used a custom
setControllerReferencemethod which would simply ignore x-namespaced resources thus potentially leaving dangling resources after theInstancewas deleted. This PR removes the method in favor ofcontroller-runtimenamespace ownership validation which returns an error should anInstancetry to deploy a x-namespaced resource. Note, that cluster-scoped resources (e.g.v1/Namespaceetc.) would still work.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com