KEP-29: Install dependencies of operators. #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing an operator package using the KUDO CLI, operator dependencies can be provided as 'KudoOperator' tasks. For each of these tasks, the respective package is resolved and its Operator and OperatorVersion installed on the cluster. Because dependent package can also have dependencies on packages, dependencies are resolved recursively. Cyclic dependencies are detected by modeling the dependencies as a directed graph and checking this graph for cycles when new dependencies are added. Signed-off-by: Jan Schlicht <jan@d2iq.com>
zen-dog
reviewed
Jun 8, 2020
Signed-off-by: Jan Schlicht <jan@d2iq.com>
nfnt
changed the title
Packages returned by 'gatherDependencies' only includes dependencies. Signed-off-by: Jan Schlicht <jan@d2iq.com>
ANeumann82
reviewed
Jun 9, 2020
ANeumann82
reviewed
Jun 9, 2020
| func Package( | ||
| client *kudo.Client, | ||
| instanceName string, | ||
| namespace string, | ||
| resources packages.Resources, | ||
| parameters map[string]string, | ||
| resolver resolver.Resolver, |
There was a problem hiding this comment.
I wonder if it would work to rename some package so we get resolver dependencies.Resolver or resolver packages.Resolver?
There was a problem hiding this comment.
hey, third time resolver is the charm! :D
Also renames some variables to make code more readable. Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
by introducing a `FullyQualifiedName` method for the `OperatorVersion` Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
the cycle error now mentions both parent and child package that cause the cycle Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When installing an operator package using the KUDO CLI, operator dependencies can be provided as KudoOperator tasks. For each of these tasks, the respective package is resolved and its
OperatorandOperatorVersioninstalled on the cluster. Because dependent package can also have dependencies on packages, dependencies are resolved recursively. Cyclic dependencies are detected by modeling the dependencies as a directed graph and checking this graph for cycles when new dependencies are added.Fixes part of #1514
Co-authored-by: Aleksey Dukhovniy adukhovniy@mesosphere.io