Fail kudo init if version is unknown. #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
kensipe
requested changes
Jun 18, 2020
There was a problem hiding this comment.
I love this! 2 Comments, 1 blocking...
- non-blocking:
not-built-on-tagis technically correct but I'm not sure conveys full meaning.not-built-on-release? I'm ok with what is there... just a thought. --imageis not the only way to over the image... (which this change assumes).--versionalso works and is likely the preferred method to get the image from the official source.--versionis to switch a version.--imageis for switch docker repository.
pkg/kudoctl/cmd/init.go
Outdated
| @@ -142,6 +142,8 @@ func (initCmd *initCmd) run() error { | |||
| // if image provided switch to it. | |||
| if initCmd.image != "" { | |||
| opts.Image = initCmd.image | |||
| } else if opts.Version == "not-built-on-tag" { | |||
| return errors.New("cannot infer controller docker image to use, please override with --kudo-image") | |||
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
|
PTAL, I:
|
…ild not built from tag Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
love this!
/lgtm
updated code to have the dev experience to be consistent with non-release build
go run cmd/kubectl-kudo/main.go init
Error: cannot infer controller docker image to use - not a released binary; please override with a command-line flag
exit status 255
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This hopefully should have no impact on developer workflows nor on how a (pre-)released build works. However in cases where a matching controller docker image does not exist, it will fail fast, rather than deploying a (potentially incompatible) controller from a docker image built for some earlier commit.
Implementation:
pkg/version.gitVersionto a version string using$LDFLAGSonly when a tagged commit is checked out (this will always be true for release builds). In other cases, set it to a sentinel value.kudo initunless the sentinel value is overridden explicitly.Fixes #1549
Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com