KEP-29: Introducing operator dependency cycle detection to the instance controller #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller Summary: Operator dependencies cycle detection is now part of the instance controller reconciliation. We execute the check for the top-level instances only, since the lower-level instances are already take care of. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
commented
Jun 11, 2020
| @@ -222,14 +221,3 @@ type InstanceList struct { | |||
| func init() { | |||
| SchemeBuilder.Register(&Instance{}, &InstanceList{}) | |||
| } | |||
|
|
|||
zen-dog
commented
Jun 11, 2020
| // In (1), i.Spec.PlanExecution.PlanName is set directly when the user updates the instance and reset **after** the plan | ||
| // is terminal | ||
| // In (2) i.Spec.PlanStatus is updated **AFTER** the instance controller is done with the reconciliation call | ||
| func (i *Instance) GetScheduledPlan() *PlanStatus { |
zen-dog
changed the title
nfnt
requested changes
Jun 12, 2020
| @@ -50,6 +50,8 @@ import ( | |||
| "github.com/kudobuilder/kudo/pkg/engine/renderer" | |||
| "github.com/kudobuilder/kudo/pkg/engine/task" | |||
| "github.com/kudobuilder/kudo/pkg/engine/workflow" | |||
| "github.com/kudobuilder/kudo/pkg/kudoctl/packages" | |||
There was a problem hiding this comment.
With package handling no longer exclusive to the CLI, let's move the packages folder up in the package hierarchy. pkg/kudoctl/packages -> pkg/packages.
There was a problem hiding this comment.
I don't mind but let's do it in a separate PR
Comment on lines
39
to
45
| return &packages.Package{ | ||
| Resources: &packages.Resources{ | ||
| Operator: o, | ||
| OperatorVersion: ov, | ||
| Instance: nil, | ||
| }, | ||
| Files: nil, |
There was a problem hiding this comment.
This is making the assumption that the dependency resolver will only parse the OperatorVersion of a package -- which it currently does. We need to make sure that this assumption is covered by a test that would fail if, e.g., the dependency resolver starts to parse Instance as well.
additionally removed `KudoOperatorTask.OperatorName` since we don't need it anymore. Fixed a few other issue too. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
nfnt
approved these changes
Jun 22, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
pushed a commit
that referenced
this pull request
Jun 22, 2020
…ce controller (#1559) Summary: Operator dependencies cycle detection is now part of the instance controller reconciliation. We execute the check for the top-level instances only since the lower-level instances are already take care of. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> (cherry picked from commit d01b859)
zen-dog
pushed a commit
that referenced
this pull request
Jun 22, 2020
…ce controller (#1559) (#1567) Summary: Operator dependencies cycle detection is now part of the instance controller reconciliation. We execute the check for the top-level instances only since the lower-level instances are already take care of. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com> Fixes #1513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Operator dependencies cycle detection is now part of the instance controller reconciliation. We execute the check for the top-level instances only since the lower-level instances are already taken care of.
Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com