Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-29: Include dependent operators in diagnostics #1570

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Jun 26, 2020

What this PR does / why we need it:
Operators that are children of other operators through dependencies are included in diagnostics bundles of their parent operator.

The diagnostics test files have been cleaned up. Everything that isn't relevant to the functionality of diagnostics collection has been removed. This will make it easier to adapt to changes in the future.

Fixes #1511

Operators that are children of other operators through dependencies are included in diagnostics bundles of their parent operator.

Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart from the objdump that doesn't need to be repeated for every child

pkg/kudoctl/cmd/diagnostics/runner_helper.go Outdated Show resolved Hide resolved
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, my only request would be for nesting dependency instances (see my comment below)

pkg/kudoctl/cmd/diagnostics/runner_helper.go Outdated Show resolved Hide resolved
Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt requested a review from zen-dog June 26, 2020 12:21
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but otherwise LGTM! 🚢

pkg/kudoctl/util/kudo/kudo.go Show resolved Hide resolved
@nfnt nfnt merged commit 6fc3086 into main Jun 29, 2020
@nfnt nfnt deleted the nfnt/diagnostics-deps branch June 29, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KEP-29]: Extend diagnostics bundle to support operator dependencies
3 participants