-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-29: Include dependent operators in diagnostics #1570
Conversation
Operators that are children of other operators through dependencies are included in diagnostics bundles of their parent operator. Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, apart from the objdump that doesn't need to be repeated for every child
Signed-off-by: Jan Schlicht <jan@d2iq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, my only request would be for nesting dependency instances (see my comment below)
Signed-off-by: Jan Schlicht <jan@d2iq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but otherwise LGTM! 🚢
What this PR does / why we need it:
Operators that are children of other operators through dependencies are included in diagnostics bundles of their parent operator.
The diagnostics test files have been cleaned up. Everything that isn't relevant to the functionality of diagnostics collection has been removed. This will make it easier to adapt to changes in the future.
Fixes #1511